From: Michael Trimarchi Date: Mon, 29 Jun 2009 14:17:52 +0200 Subject: [U-Boot] [PATCH 4/6] usb: bugfix driver/usb/host/ehci-hcd.c function ehci_submit_root In-Reply-To: <1246289178-18711-1-git-send-email-prafulla@marvell.com> References: <1246289178-18711-1-git-send-email-prafulla@marvell.com> Message-ID: <4A48B0F0.8070903@gandalf.sssup.it> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Prafulla Wadaskar wrote: > Signed-off-by: Prafulla Wadaskar > --- > drivers/usb/host/ehci-hcd.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c > index bbd547b..7a55638 100644 > --- a/drivers/usb/host/ehci-hcd.c > +++ b/drivers/usb/host/ehci-hcd.c > @@ -550,7 +550,7 @@ ehci_submit_root(struct usb_device *dev, unsigned long pipe, void *buffer, > req->requesttype, req->requesttype, > le16_to_cpu(req->value), le16_to_cpu(req->index)); > > - typeReq = req->request << 8 | req->requesttype; > + typeReq = req->request | req->requesttype << 8; > Sorry, but I'm not sure in this inversion. Are your sure? > > switch (le16_to_cpu(typeReq)) { > Maybe this one has no sense... Michael > case DeviceRequest | USB_REQ_GET_DESCRIPTOR: >