From: Avi Kivity Subject: Re: [PATCH 1/5] BIOS changes for irq0->inti2 override (v9) Date: Wed, 08 Jul 2009 15:01:49 +0300 Message-ID: <4A548AAD.8030209@redhat.com> References: <1246981838-20465-1-git-send-email-eak@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Beth Kon Return-path: Received: from mx2.redhat.com ([66.187.237.31]:55940 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753753AbZGHL7a (ORCPT ); Wed, 8 Jul 2009 07:59:30 -0400 In-Reply-To: <1246981838-20465-1-git-send-email-eak@us.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: On 07/07/2009 06:50 PM, Beth Kon wrote: > bios: allow qemu to configure irq0->inti2 override > > Win2k8 expects the HPET interrupt on inti2, regardless of whether > an override exists in the BIOS. And the HPET spec states that in legacy mode, > timer interrupt is on inti2. > > The irq0->inti2 override will always be used unless the kernel cannot do irq > routing (i.e., compatibility with old kernels). So if the kernel is capable, > userspace sets up irq0->inti2 via the irq routing interface, and adds the > irq0->inti2 override to the MADT interrupt source override table, > and the mp table (for the no-acpi case). > > Changes from v8 - Incorporated Gleb's comments to patch 1/5 and 4/5. > In 1/5, removed a "return" per Gleb's comment. > See 4/5 for v8->v9 change description. > > This series doesn't boot for me - Linux says the 8254 is not connected to ioapic. I pushed it as the 'hpet' branch again, can you take a look? -- error compiling committee.c: too many arguments to function