From: Avi Kivity Subject: Re: [PATCH] virtio_blk: ioctl return value fix Date: Wed, 08 Jul 2009 22:46:03 +0300 Message-ID: <4A54F77B.80008@redhat.com> References: <20090620192941.GA26873@lst.de> <200906231643.10623.rusty@rustcorp.com.au> <20090708181220.GB10552@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Rusty Russell , linux-kernel@vger.kernel.org, kvm@vger.kernel.org To: Christoph Hellwig Return-path: Received: from mx2.redhat.com ([66.187.237.31]:46287 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755301AbZGHTpz (ORCPT ); Wed, 8 Jul 2009 15:45:55 -0400 In-Reply-To: <20090708181220.GB10552@lst.de> Sender: kvm-owner@vger.kernel.org List-ID: On 07/08/2009 09:12 PM, Christoph Hellwig wrote: > On Tue, Jun 23, 2009 at 04:43:10PM +0930, Rusty Russell wrote: > >> On Sun, 21 Jun 2009 04:59:41 am Christoph Hellwig wrote: >> >>> Block driver ioctl methods must return ENOTTY and not -ENOIOCTLCMD if >>> they expect the block layer to handle generic ioctls. >>> >>> This triggered a BLKROSET failure in xfsqa #200. >>> >> Applied. >> > > Can you send on this fix to Linus? It fixes a regression introduced in > Linux 2.6.30. > > It should set the Cc: stable@kernel.org marker then. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.