From: =?ISO-8859-1?Q?Richard_R=F6jfors?= Subject: [PATCH 1/1] tsc2007: Cancel work sync, increase polling frequency, make exit platform hw callback optional Date: Thu, 09 Jul 2009 18:53:07 +0200 Message-ID: <4A562073.1080703@mocean-labs.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from av11-1-sn2.hy.skanova.net ([81.228.8.183]:38662 "EHLO av11-1-sn2.hy.skanova.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760852AbZGIQxL (ORCPT ); Thu, 9 Jul 2009 12:53:11 -0400 Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: linux-input@vger.kernel.org Cc: Linux Kernel Mailing List , Andrew Morton , kwangwoo.lee@gmail.com, Thierry Reding , soni.trilok@gmail.com In the remove function, ancel the work using the _sync version, to make sure any running "work" is finished. Make the exit_platform_hw callback optional since it's not needed on all platforms. When the screen is touched, the polling frequency is increased to reduce the risk of missing taps. Signed-off-by: Richard R=F6jfors --- Index: linux-2.6.30/drivers/input/touchscreen/tsc2007.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- linux-2.6.30/drivers/input/touchscreen/tsc2007.c (revision 945) +++ linux-2.6.30/drivers/input/touchscreen/tsc2007.c (revision 999) @@ -27,7 +27,7 @@ #include #include -#define TS_POLL_PERIOD msecs_to_jiffies(5) /* ms delay between samples= */ +#define TS_POLL_PERIOD msecs_to_jiffies(1) /* ms delay between samples= */ #define TSC2007_MEASURE_TEMP0 (0x0 << 4) #define TSC2007_MEASURE_AUX (0x2 << 4) @@ -332,11 +332,11 @@ struct tsc2007 *ts =3D i2c_get_clientdata(client); struct tsc2007_platform_data *pdata; - /* cancel any work */ - cancel_delayed_work(&ts->work); + cancel_delayed_work_sync(&ts->work); pdata =3D client->dev.platform_data; - pdata->exit_platform_hw(); + if (pdata->exit_platform_hw) + pdata->exit_platform_hw(); free_irq(ts->irq, ts); input_unregister_device(ts->input); -- To unsubscribe from this list: send the line "unsubscribe linux-input" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html