From: Jens Scharsig Date: Mon, 20 Jul 2009 08:45:06 +0200 Subject: [U-Boot] [PATCH 1/2] new video driver for bus vcxk framebuffers In-Reply-To: <4A61FE3A.9070500@denx.de> References: <4A61FE3A.9070500@denx.de> Message-ID: <4A641272.9050504@bus-elektronik.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Anatolij, >> +initialize the reset line to vcxk hardware and release it from reset > > Looking on the changes to board configuration file > "include/configs/EB+MCF-EV123.h" in the second patch of this series > I now realize that most of these CONFIG_SYS_ macros above expand to > C code, so these are not configuration options any more. > I tend to reject all this. CONFIG_SYS_ options are supposed to be options > and not board specific code. VCxK.c driver you removed by this patch > series did it in more correct way, I think. > What about moving this code to functions which use board specific macros? > These functions should be placed in this new video driver then. > I will complete review the code. I think, i can sent a new patch set within one week Best regards, Jens Scharsig