Received: from [209.85.219.223] (helo=mail-ew0-f223.google.com) by linuxtogo.org with esmtp (Exim 4.69) (envelope-from ) id 1MWmWO-0002bw-Lj for openembedded-devel@lists.openembedded.org; Fri, 31 Jul 2009 09:27:20 +0200 Received: by ewy23 with SMTP id 23so1253214ewy.12 for ; Fri, 31 Jul 2009 00:12:13 -0700 (PDT) Received: by 10.210.41.10 with SMTP id o10mr2684509ebo.33.1249024332088; Fri, 31 Jul 2009 00:12:12 -0700 (PDT) Received: from ?192.168.1.64? (94-193-93-235.zone7.bethere.co.uk [94.193.93.235]) by mx.google.com with ESMTPS id 7sm3841512eyg.25.2009.07.31.00.12.10 (version=SSLv3 cipher=RC4-MD5); Fri, 31 Jul 2009 00:12:11 -0700 (PDT) Message-ID: <4A729943.4060200@xora.org.uk> Date: Fri, 31 Jul 2009 08:12:03 +0100 From: Graeme Gregory User-Agent: Thunderbird 2.0.0.22 (Windows/20090605) MIME-Version: 1.0 To: openembedded-devel@lists.openembedded.org References: <4A6FD077.1060001@gmail.com> <4A700A74.7040507@xora.org.uk> <200907291131.04967.marcin@juszkiewicz.com.pl> <6ec4247d0907292211w6afc1f60s9fcf21bc7b2d56d3@mail.gmail.com> <20090730053353.GF25691@smtp.west.cox.net> <6ec4247d0907292249k42c582ddid3d53e847c5f835d@mail.gmail.com> <4A7160F2.8030000@xora.org.uk> <4A7255D3.9020703@gmail.com> In-Reply-To: <4A7255D3.9020703@gmail.com> Subject: Re: [PATCH] remove duplicated code from linux.inc X-BeenThere: openembedded-devel@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: openembedded-devel@lists.openembedded.org List-Id: Using the OpenEmbedded metadata to build Distributions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Jul 2009 07:27:20 -0000 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Graham Gower wrote: > Graeme Gregory wrote: >> Why dont you prepend it to the current uImage creation code running >> only conditionally on UBOOT_ENTRYSYMBOL being set? As its in the same >> bit of shell code your resetting of UBOOT_ENTRYPOINT will take >> precedence! Also means other machines can use it. > > Once I realised that ${FOO} is replaced before the shell function is run, > while $FOO is not, things made a lot more sense. > > Allow a dynamic entry point via UBOOT_ENTRYSYMBOL and remove redundant > uboot-mkimage code in kernel.bbclass. > Looks good to me, do you fancy moving that do_compile_append into kernel.bbclass? You can then have the added kudos of fixing OE core files :-) Graeme