From: Jeremy Fitzhardinge <jeremy@goop.org>
Subject: Re: [PATCH] xen: xen_init_cpuid_mask: Zero cx before
	calling xen_cpuid
Date: Sat, 15 Aug 2009 00:02:30 -0700
Message-ID: <4A865D86.2050002@goop.org>
References: <20090808201500.GA21828@feather>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <20090808201500.GA21828@feather>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Josh Triplett <josh@joshtriplett.org>
Cc: Andrew Morton <akpm@linux-foundation.org>, xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org, Jeremy Fitzhardinge <jeremy@xensource.com>
List-Id: xen-devel@lists.xenproject.org

On 08/08/09 13:15, Josh Triplett wrote:
> CPUID function 1 doesn't use cx, but xen_cpuid doesn't know that,
> resulting in this warning:
>
> arch/x86/xen/enlighten.c: In function =E2=80=98xen_start_kernel=E2=80=99=
:
> arch/x86/xen/enlighten.c:192: warning: =E2=80=98cx=E2=80=99 may be used=
 uninitialized in this function
> arch/x86/xen/enlighten.c:205: note: =E2=80=98cx=E2=80=99 was declared h=
ere
>
> Set cx =3D 0 to avoid this warning.  This seems preferable to implement=
ing
> a xen_cpuid_nocount without the input constraint for cx, and either of
> those seem preferable to just ignoring the warning.
>  =20

Thanks, applied.

    J