From: Sebastian Andrzej Siewior Subject: Re: [RFC] net/fs_enet: send a reset request to the PHY on init Date: Fri, 04 Sep 2009 17:38:34 +0200 Message-ID: <4AA1347A.5060702@linutronix.de> References: <20090902110410.GC15401@www.tglx.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Cc: linuxppc-dev@ozlabs.org, netdev@vger.kernel.org, Vitaly Bordug To: Grant Likely Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@lists.ozlabs.org List-Id: netdev.vger.kernel.org Grant Likely wrote: > What version of the kernel are you using? The line numbers don't > match up with kernel mainline, so I wonder if this is before or after > the OF MDIO rework changes. It is the kernel which was shipped in ads5121's bsp which is 2.6.24. > Regardless, this doesn't look right. It certainly isn't right for the > driver to do an unconditional PHY reset when it doesn't actually know > what phy is attached. For most boards I'm sure this is not desirable > because it will cause a delay while the PHY auto negotiates. > Depending on when the first network traffic begins, can cause several > seconds of boot delay. > > Best would be to do this in U-Boot. Otherwise, I think I would rather > see it at phy_device probe time. At least then it would be on a > per-phy basis, or could be controlled by a property in the device tree > so that all boards don't get the same impact. I have no network support in boot loader so I can't do it there. Doing it at phy-probe time sounds reasonable. So all other boards are doing this kind of reset in u-boot? > g. > Sebastian