From: "Jun'ichi Nomura" Subject: Re: [PATCH 1/3] block: Add blk_queue_copy_limits() Date: Tue, 22 Sep 2009 01:33:38 +0900 Message-ID: <4AB7AAE2.8000404@ce.jp.nec.com> References: <4AB3B43D.9000802@ce.jp.nec.com> <4AB4F74E.7000908@ce.jp.nec.com> Reply-To: device-mapper development Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Jens Axboe , "Martin K. Petersen" Cc: device-mapper development , Mike Snitzer , Alasdair G Kergon , linux-kernel@vger.kernel.org List-Id: dm-devel.ids Martin K. Petersen wrote: >>>>>> "Jun'ichi" == Jun'ichi Nomura writes: > > Jun'ichi> Umm, with this, BLK_DEF_MAX_SECTORS becomes upper bound of > Jun'ichi> max_hw_sectors and the values of underlying devices are not > Jun'ichi> propagated to the stacking devices. > > Well, max_sectors is already bounded by this. max_hw_sectors only > really matters for PC commands, so I'm not sure it's a big deal for > DM. But I guess we could set the default max_hw_sectors to -1. > > I'm just trying to avoid these scattered if-0-set-it-to-something-else > cases. I'd much rather have the defaults do the right thing. I agree with that. I had to do the if-0-set-it-to-something-else to avoid putting unnecessary cap on max_hw_sectors. If we aren't sure, shouldn't we set its default to -1 or putting comments in blk_set_default_limits() at least to avoid possible confusion in future? Thanks, -- Jun'ichi Nomura, NEC Corporation