From: Jeremy Fitzhardinge Subject: Re: [GIT PULL] xen: Check NX state before setting up GDT mapping Date: Wed, 23 Sep 2009 12:03:53 -0700 Message-ID: <4ABA7119.6000307@goop.org> References: <4AB7EC1D.5010102@goop.org> <20090923123616.GC19385@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20090923123616.GC19385@elte.hu> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ingo Molnar Cc: Xen-devel , Linux Kernel Mailing List , Ingo Molnar , the arch/x86 maintainers , Stable Kernel List-Id: xen-devel@lists.xenproject.org On 09/23/09 05:36, Ingo Molnar wrote: >> +#ifdef CONFIG_X86_64 >> + /* Work out if we support NX */ >> + check_efer(); >> +#endif >> + >> > btw., this #ifdef could sure be eliminated, right? > check_efer() is only defined on x86-64 and all its existing callsites have a similar #ifdef. NX setup is an area which could do with a bit of hitting with the unification stick. J