Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MvvJZ-0005OA-B9 for qemu-devel@nongnu.org; Thu, 08 Oct 2009 11:54:01 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MvvJU-0005JY-BD for qemu-devel@nongnu.org; Thu, 08 Oct 2009 11:54:00 -0400 Received: from [199.232.76.173] (port=45272 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MvvJT-0005JE-Vb for qemu-devel@nongnu.org; Thu, 08 Oct 2009 11:53:56 -0400 Received: from thoth.sbs.de ([192.35.17.2]:15365) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MvvJT-0001Fo-EC for qemu-devel@nongnu.org; Thu, 08 Oct 2009 11:53:55 -0400 Message-ID: <4ACE0B0A.9060205@siemens.com> Date: Thu, 08 Oct 2009 17:53:46 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1254953315-5761-1-git-send-email-glommer@redhat.com> <1254953315-5761-2-git-send-email-glommer@redhat.com> <1254953315-5761-3-git-send-email-glommer@redhat.com> <1254953315-5761-4-git-send-email-glommer@redhat.com> <4ACDEDEC.60706@us.ibm.com> <4ACDEF03.6010406@redhat.com> In-Reply-To: <4ACDEF03.6010406@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH v2 3/9] provide in-kernel ioapic List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: Anthony Liguori , Glauber Costa , kvm-devel , qemu-devel@nongnu.org Avi Kivity wrote: > On 10/08/2009 03:49 PM, Anthony Liguori wrote: >> Glauber Costa wrote: >>> This patch provides kvm with an in-kernel ioapic. We are currently >>> not enabling it. >>> The code is heavily based on what's in qemu-kvm.git. >> >> It really ought to be it's own file and own device model. Having the >> code mixed in with ioapic.c is confusing because it's unclear what >> code is in use when the in-kernel model is used. > > I disagree. It's the same device with the same guest-visible interface > and the same host-visible interface (save/restore, 'info ioapic' if we > write one). Splitting it into two files will only result in code > duplication. Shared functions can be pushed into a commonly used module (ioapic-common.c). And everyone touching it should realize then that it could affect more than one user. Jan -- Siemens AG, Corporate Technology, CT SE 2 Corporate Competence Center Embedded Linux