From: ryan@bluewatersys.com (Ryan Mallon) Date: Wed, 21 Oct 2009 13:55:47 +1300 Subject: [PATCH] ep93xx: add errata info about pwm outputs In-Reply-To: References: Message-ID: <4ADE5C13.6000502@bluewatersys.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org H Hartley Sweeten wrote: > The EP93xx User's guide has an error about the number of pwm > channels available in the various chips. Add comments about > this in the driver since the guide will probably never get > updated. > > EP9301/02 only have pwm.1, pin PMWOUT is not on the chip > EP9307 only has pwm.0, pin PWMOUT1 (EGPIO14) is not on the chip > EP9312/15 have both pwm0 and pwm.1 > > Signed-off-by: H Hartley Sweeten > Cc: Ryan Mallon > > --- > > diff --git a/arch/arm/mach-ep93xx/core.c b/arch/arm/mach-ep93xx/core.c > index f95dc16..f30be28 100644 > --- a/arch/arm/mach-ep93xx/core.c > +++ b/arch/arm/mach-ep93xx/core.c > @@ -648,6 +648,7 @@ static struct platform_device ep93xx_pwm1_device = { > > void __init ep93xx_register_pwm(int pwm0, int pwm1) > { > + /* NOTE: EP9301/02 do not have PWMOUT */ > if (pwm0) > platform_device_register(&ep93xx_pwm0_device); > > diff --git a/drivers/misc/ep93xx_pwm.c b/drivers/misc/ep93xx_pwm.c > index ba46941..de9f405 100644 > --- a/drivers/misc/ep93xx_pwm.c > +++ b/drivers/misc/ep93xx_pwm.c > @@ -9,12 +9,18 @@ > * as published by the Free Software Foundation; either version > * 2 of the License, or (at your option) any later version. > * > - * EP9307 has only one channel: > - * - PWMOUT > + * The EP93xx User's Guide has an error about the number of pwm channels > + * available in the various chips. Is there an official errata for this that we can link to? ~Ryan -- Bluewater Systems Ltd - ARM Technology Solution Centre Ryan Mallon 5 Amuri Park, 404 Barbadoes St ryan at bluewatersys.com PO Box 13 889, Christchurch 8013 http://www.bluewatersys.com New Zealand Phone: +64 3 3779127 Freecall: Australia 1800 148 751 Fax: +64 3 3779135 USA 1800 261 2934