From: Jeremy Fitzhardinge Subject: Re: pv 2.6.31 (kernel.org) and save/migrate fails, domU BUG Date: Thu, 12 Nov 2009 15:36:31 -0800 Message-ID: <4AFC9BFF.9030707@goop.org> References: <20091108154153.GM1434@reaktio.net> <693ea516-aa5b-4f82-ad48-1bd51cfa3480@default> <20091108172747.GR1434@reaktio.net> <20091110100806.GE16033@reaktio.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20091110100806.GE16033@reaktio.net> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: =?ISO-8859-1?Q?Pasi_K=E4rkk=E4inen?= Cc: Dan Magenheimer , "Xen-Devel (E-mail)" List-Id: xen-devel@lists.xenproject.org On 11/10/09 02:08, Pasi K=E4rkk=E4inen wrote: > Hello, > > Jeremy: Here's summary about these save/restore problems > using upstream Linux 2.6.31.5 PV guest. > > For me: > - I can "xm save" + "xm restore" UP guest, but I get non-fatal > BUG in the guest kernel, see [1]. > - "xm save" fails for SMP guest with "failed to get the suspend evtchn= port", see [2]. > > For Dan: > - "xm save" works for UP guest, but "xm restore" doesn't, giving > infinite xen_sched_clock related dumps in the guest kernel, see [3]. > - "xm save" for SMP guest fails, it never ends. I suspect this > is the same problem I'm seeing. > > > [1] non-fatal BUG on the guest kernel after "xm restore": > http://pasik.reaktio.net/xen/debug/dmesg-2.6.31.5-122.fc12.x86_64-saver= estore.txt > =20 Does this help: diff --git a/drivers/xen/manage.c b/drivers/xen/manage.c index 10d03d7..da57ea1 100644 --- a/drivers/xen/manage.c +++ b/drivers/xen/manage.c @@ -43,7 +43,6 @@ static int xen_suspend(void *data) if (err) { printk(KERN_ERR "xen_suspend: sysdev_suspend failed: %d\n", err); - dpm_resume_noirq(PMSG_RESUME); return err; } =20 @@ -69,7 +68,6 @@ static int xen_suspend(void *data) } =20 sysdev_resume(); - dpm_resume_noirq(PMSG_RESUME); =20 return 0; } @@ -108,6 +106,9 @@ static void do_suspend(void) } =20 err =3D stop_machine(xen_suspend, &cancelled, cpumask_of(0)); + + dpm_resume_noirq(PMSG_RESUME); + if (err) { printk(KERN_ERR "failed to start xen_suspend: %d\n", err); goto out; > [2] "xm log" contains: > [2009-11-09 23:44:38 1353] DEBUG (XendCheckpoint:110) [xc_save]: /usr/l= ib64/xen/bin/xc_save 28 2 0 0 0 > [2009-11-09 23:44:38 1353] INFO (XendCheckpoint:417) xc_save: failed to= get the suspend evtchn port > =20 I think this may be a Remus side-effect. > [3] See the attachment in this email: > http://lists.xensource.com/archives/html/xen-devel/2009-11/msg00391.htm= l > =20 No idea about this one. Needs a closer look. J