From: Damian Lukowski Subject: Re: scp stalls mysteriously Date: Sat, 05 Dec 2009 23:32:25 +0100 Message-ID: <4B1ADF79.6000101@tvk.rwth-aachen.de> References: <20091130213727.2f4047d2@houba> <20091201211945.505d3c98@houba> <20091202085925.472136e2@houba> <20091202154403.GB30730@sd-11162.dedibox.fr> <20091202183451.173db5f2@houba> <4B16BD58.3040802@tvk.rwth-aachen.de> <20091203085933.GD30730@sd-11162.dedibox.fr> <4B17A791.80808@tvk.rwth-aachen.de> <4B17C6C3.1060000@tvk.rwth-aachen.de> <20091203202328.62d7551a@houba> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: =?UTF-8?B?SWxwbyBKw6RydmluZW4=?= , Netdev , David Miller , Eric Dumazet , Herbert Xu , Greg KH To: Frederic Leroy Return-path: Received: from mta-1.ms.rz.RWTH-Aachen.DE ([134.130.7.72]:38144 "EHLO mta-1.ms.rz.rwth-aachen.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755258AbZLEWcU (ORCPT ); Sat, 5 Dec 2009 17:32:20 -0500 Received: from ironport-out-1.rz.rwth-aachen.de ([134.130.5.40]) by mta-1.ms.rz.RWTH-Aachen.de (Sun Java(tm) System Messaging Server 6.3-7.04 (built Sep 26 2008)) with ESMTP id <0KU7006ZSAM13590@mta-1.ms.rz.RWTH-Aachen.de> for netdev@vger.kernel.org; Sat, 05 Dec 2009 23:32:25 +0100 (CET) In-reply-to: <20091203202328.62d7551a@houba> Sender: netdev-owner@vger.kernel.org List-ID: =46rederic Leroy schrieb: > Le Thu, 03 Dec 2009 15:10:11 +0100, > Damian Lukowski a =C3=A9crit : >>> I suppose adding || !tp->retrans_stamp into the false condition is >>> fine as long as we don't then have a connection that can cause a >>> connection to hang there forever for some reason (this needs to be >>> understood well enough, not just test driven in stables :-)). >>> >>>> Unluckily, I still cannot reproduce the scp stalls here, so it >>>> would be nice if Frederic printed retrans_stamp together with >>>> icsk_ca_state and icsk_retransmits, please. >>> It wouldn't hurt to know tp->packets_out and tp->retrans_out too, >>> that might have some significant w.r.t what happens because of FRTO= =2E >> I made a patch for Frederic with Codebase >> git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git >> >> Thanks for testing. >=20 > I made a new .11 trace with damian patch. > The copy went to the end. Could you please make another test and unplug the cable or drop ACKs fo= r several seconds, so that some RTO retransmissions are performed? I'd like to see if retrans_stamp remains constant. In the dmesg output = of the 11th run, it seems to change while icsk_retransmits also increases. This is kind of bad for connection timeout calculation in the RTO case = =2E.. Damian =20 > http://www.starox.org/pub/scp_stall/scp_stall-houba.11-patch_damian.p= cap.bz2 > http://www.starox.org/pub/scp_stall/scp_stall-houba.11-patch_damian.d= mesg.bz2 > http://www.starox.org/pub/scp_stall/scp_stall-houba.11-patch_damian.p= roc_net_netstat-before.bz2 > http://www.starox.org/pub/scp_stall/scp_stall-houba.11-patch_damian.p= roc_net_netstat-after.bz2 > http://www.starox.org/pub/scp_stall/scp_stall-houba.11-patch_damian.s= ysctl_net.ipv4.tcp-before.bz2