From: Avi Kivity Subject: Re: [PATCH] kvm: only allow one gsi per fd Date: Wed, 20 Jan 2010 13:52:00 +0200 Message-ID: <4B56EE60.4030009@redhat.com> References: <20100113165809.GA13334@redhat.com> <4B53052D.3020905@redhat.com> <20100120113641.GB9610@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , Gregory Haskins , Gleb Natapov , Julia Lawall , kvm@vger.kernel.org, linux-kernel@vger.kernel.org To: "Michael S. Tsirkin" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:15598 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753340Ab0ATLwI (ORCPT ); Wed, 20 Jan 2010 06:52:08 -0500 In-Reply-To: <20100120113641.GB9610@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 01/20/2010 01:36 PM, Michael S. Tsirkin wrote: > On Sun, Jan 17, 2010 at 02:40:13PM +0200, Avi Kivity wrote: > >> On 01/13/2010 06:58 PM, Michael S. Tsirkin wrote: >> >>> Looks like repeatedly binding same fd to multiple gsi's with irqfd can >>> use up a ton of kernel memory for irqfd structures. >>> >>> A simple fix is to allow each fd to only trigger one gsi: triggering a >>> srorm of interrupts in guest is likely useless anyway, and we can do it >>> by binding a single gsi to many interrupts if we really want to. >>> >>> >> Applied and queued, thanks. >> > I'm guessing we need this for 2.6.32 stable and 2.6.33 as well? > That's what 'queued' means. -- error compiling committee.c: too many arguments to function