From: Avi Kivity Subject: Re: [PATCH 0/2] kvm: fix spurious interrupt with irqfd Date: Wed, 20 Jan 2010 17:09:32 +0200 Message-ID: <4B571CAC.9000902@redhat.com> References: <20100113171222.GA19798@redhat.com> <4B5305CA.5070001@redhat.com> <20100119145202.GC28465@redhat.com> <4B570EDD.6000808@redhat.com> <20100120145822.GB3434@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: mtosatti@redhat.com, Davide Libenzi , kvm@vger.kernel.org, Linux Kernel Mailing List To: "Michael S. Tsirkin" Return-path: In-Reply-To: <20100120145822.GB3434@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 01/20/2010 04:58 PM, Michael S. Tsirkin wrote: > >> I'm uncomfortable with pushing Davide's patch into stable and possibly >> causing regressions with unrelated applications. Can't a guest live >> with a spurious interrupt? >> > Well guests mask/unmask vector on each interrupt, so this will trigger > an irq storm I think. > > >> It's not like they're unknown. >> > Depends on the device really. > In theory, if they trigger at an unfortunate time this could cause > crashes. > > I'd like confirmation on both of these before I push things to stable. -- error compiling committee.c: too many arguments to function