From: Randy Dunlap Date: Thu, 11 Feb 2010 17:01:35 +0000 Subject: Re: bug list: putting too much data on the stack Message-Id: <4B7437EF.2050001@xenotime.net> List-Id: References: <20100211085120.GF14210@bicker> In-Reply-To: <20100211085120.GF14210@bicker> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org On 02/11/10 00:51, Dan Carpenter wrote: > This is a list of functions that put a lot of data (500 bytes) on the stack. > I don't know if 500 is reasonable, but I've seen people complaining about > smaller amounts. > > The list was generated by: > make C=1 CHECK="/path/to/smatch -p=kernel" modules bzImage | tee warns.txt > grep "bytes on stack" warns.txt > > regards, > dan carpenter > > Previous bug lists: > * Assigning negative values to unsigned variables > http://lkml.indiana.edu/hypermail/linux/kernel/1001.3/01222.html > > * Doing dma on the stack > http://lkml.indiana.edu/hypermail/linux/kernel/1001.3/01231.html > > * Dereferencing variables before verifying they are not null > http://lkml.indiana.edu/hypermail/linux/kernel/1001.3/01980.html > ... > drivers/media/dvb/frontends/dib3000mc.c +816 dib3000mc_i2c_enumeration(2) warn: 'st' puts 1416 bytes on stack > drivers/media/dvb/frontends/dib7000p.c +1326 dib7000p_i2c_enumeration(2) warn: 'st' puts 1468 bytes on stack I posted patches for these a few days ago. Andrew put them into mmotm. linux-media hasn't responded to them yet. http://patchwork.kernel.org/patch/77892/ http://patchwork.kernel.org/patch/77891/ -- ~Randy