From: Andreas Petlund Subject: Re: [net-next PATCH v4 1/3] net: TCP thin-stream detection Date: Mon, 22 Feb 2010 16:40:22 +0100 Message-ID: <4B82A566.5000600@simula.no> References: <20100221102102.GB1311@ucw.cz> <2EC47E8B-BC4C-4DAB-86ED-F702D67F8AD0@nokia.com> <20100221.150311.193707249.davem@davemloft.net> <87k4u5mh9u.fsf@basil.nowhere.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Lars Eggert , David Miller , "zimmermann@nets.rwth-aachen.de" , "pavel@ucw.cz" , "netdev@vger.kernel.org" , "ilpo.jarvinen@helsinki.fi" , "eric.dumazet@gmail.com" , "Arnd.Hannemann@nets.rwth-aachen.de" , "linux-kernel@vger.kernel.org" , "shemminger@vyatta.com" , "william.allen.simpson@gmail.com" , "damian@tvk.rwth-aachen.de" , "ebiederm@xmission.com" To: Andi Kleen Return-path: Received: from mail.2750.no ([62.101.244.198]:54101 "EHLO mail.2750.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753770Ab0BVPkb (ORCPT ); Mon, 22 Feb 2010 10:40:31 -0500 In-Reply-To: <87k4u5mh9u.fsf@basil.nowhere.org> Sender: netdev-owner@vger.kernel.org List-ID: On 22. feb. 2010 16:17, Andi Kleen wrote: > Lars Eggert writes: > >> If it's off by default there is no issue. > > Still a sufficient large number of people might turn it on > and then the network would melt. > > IMHO TCP changes with badly understood congestion behaviour > should not be merged until the necessary analysis/simulation etc. > is done. > > -Andi Graphs from our experiments can be found here: http://simula.no/research/nd/publications/Simula.nd.477/simula_pdf_file Section 5.2.5 covers experiments on fairness-issues. We have found no adverse effects of the modifications submitted in this patch set (mFR and LT in the plot), but further testing cannot hurt. Best regards, Andreas