Message-ID: <4B97BE9C.4010203@...1114...> Date: Wed, 10 Mar 2010 16:45:32 +0100 From: David Sommerseth MIME-Version: 1.0 References: <1267391523-1123-1-git-send-email-openvpn.list@...1114...> <201002282326.32573.dave_br@...1278...> In-Reply-To: <201002282326.32573.dave_br@...1278...> Subject: Re: [Openvpn-devel] [PATCH] bash->bourne script cleanup List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit To: Davide Brini Cc: openvpn-devel@lists.sourceforge.net -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 01/03/10 00:26, Davide Brini wrote: > On Sunday 28 February 2010, David Sommerseth wrote: >> From: Dan Nelson >> >> Many of the scripts in the openvpn source have their shell set to >> /bin/bash, but only two use bash features. The attached patch (against >> openvpn-2.1_rc9) sets the shell on the rest of the scripts to /bin/sh for >> better portability. The only scripts that actually require bash are >> contrib/pull-resolv-conf/client.{up,down} ; they use the ${!var} variable >> indirection feature. > > Not only that, they also use arrays, which are not part of standard sh. > > For a POSIX-sh compliant solution thad does mostly the same thing (and handles > multiple DOMAIN options as well, which client.{up,down} doesn't support), I > suggest you look into the Gentoo-provided {up,down}.sh scripts (though they > contain some Gentoo-specific parts, but those are easily removed). > Agreed! If you have time to look at a patch for it, I'd appreciate that. It will go in as a separate patch, to keep the patch flow as simple as possible. kind regards, David Sommerseth -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iEYEARECAAYFAkuXvpwACgkQDC186MBRfrrvAACdEkubTxrMsJUPLErrp2WVckDP vt8AoJx8VGtZ37YMiLI8AR+wXUnEHN8g =W9YB -----END PGP SIGNATURE-----