From: Takuya Yoshikawa Subject: Re: [PATCH -v3 1/2] KVM: introduce kvm_uninit_mmu_notifier() Date: Fri, 12 Mar 2010 19:12:02 +0900 Message-ID: <4B9A1372.2070900@oss.ntt.co.jp> References: <20100312120523.1b147c58.yoshikawa.takuya@oss.ntt.co.jp> <20100312185751.f113f603.yoshikawa.takuya@oss.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, Wei Yongjun To: avi@redhat.com, mtosatti@redhat.com Return-path: Received: from serv2.oss.ntt.co.jp ([222.151.198.100]:41926 "EHLO serv2.oss.ntt.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932238Ab0CLKJ1 (ORCPT ); Fri, 12 Mar 2010 05:09:27 -0500 In-Reply-To: <20100312185751.f113f603.yoshikawa.takuya@oss.ntt.co.jp> Sender: kvm-owner@vger.kernel.org List-ID: I made this patch for the coalesced mmio's error handling work. Though, I wanted to finish this work, I have no time this week any more. I'll do the remaining part next week, sorry. Takuya Yoshikawa wrote: > We have kvm_init_mmu_notifier() for registering mmu notifier. > This patch makes the counterpart for unregister. > > Signed-off-by: Takuya Yoshikawa > --- > virt/kvm/kvm_main.c | 16 +++++++++++----- > 1 files changed, 11 insertions(+), 5 deletions(-) > > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > index e758ef7..64b792c 100644 > --- a/virt/kvm/kvm_main.c > +++ b/virt/kvm/kvm_main.c > @@ -359,6 +359,11 @@ static int kvm_init_mmu_notifier(struct kvm *kvm) > return mmu_notifier_register(&kvm->mmu_notifier, current->mm); > } > > +static void kvm_uninit_mmu_notifier(struct kvm *kvm) > +{ > + mmu_notifier_unregister(&kvm->mmu_notifier, kvm->mm); > +} > + > #else /* !(CONFIG_MMU_NOTIFIER && KVM_ARCH_WANT_MMU_NOTIFIER) */ > > static int kvm_init_mmu_notifier(struct kvm *kvm) > @@ -366,6 +371,11 @@ static int kvm_init_mmu_notifier(struct kvm *kvm) > return 0; > } > > +static void kvm_uninit_mmu_notifier(struct kvm *kvm) > +{ > + kvm_arch_flush_shadow(kvm); > +} > + > #endif /* CONFIG_MMU_NOTIFIER && KVM_ARCH_WANT_MMU_NOTIFIER */ > > static struct kvm *kvm_create_vm(void) > @@ -485,11 +495,7 @@ static void kvm_destroy_vm(struct kvm *kvm) > for (i = 0; i < KVM_NR_BUSES; i++) > kvm_io_bus_destroy(kvm->buses[i]); > kvm_coalesced_mmio_free(kvm); > -#if defined(CONFIG_MMU_NOTIFIER) && defined(KVM_ARCH_WANT_MMU_NOTIFIER) > - mmu_notifier_unregister(&kvm->mmu_notifier, kvm->mm); > -#else > - kvm_arch_flush_shadow(kvm); > -#endif > + kvm_uninit_mmu_notifier(kvm); > kvm_arch_destroy_vm(kvm); > hardware_disable_all(); > mmdrop(mm);