From: Jiri Slaby <jirislaby@gmail.com>
Date: Thu, 01 Apr 2010 16:52:37 +0000
Subject: Re: [patch] mxser: spin_lock() => spin_lock_irq()
Message-Id: <4BB4CF55.8000400@gmail.com>
List-Id: <kernel-janitors.vger.kernel.org>
References: <20100401155143.GC5265@bicker>
In-Reply-To: <20100401155143.GC5265@bicker>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: Dan Carpenter <error27@gmail.com>, Alan Cox <alan@linux.intel.com>, Greg Kroah-Hartman <gregkh@suse.de>, Andrew Morton <akpm@linux-foundation.org>, Alexey Dobriyan <adobriyan@gmail.com>, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org

On 04/01/2010 05:51 PM, Dan Carpenter wrote:
> This should be spin_lock_irq() to match the spin_unlock_irq().
> Originally it was a lock_kernel() but we switched everything to
> spin_lock_irq() last November.
>
> Signed-off-by: Dan Carpenter<error27@gmail.com>
>
> diff --git a/drivers/char/mxser.c b/drivers/char/mxser.c
> index e0c5d2a..ecb2d8b 100644
> --- a/drivers/char/mxser.c
> +++ b/drivers/char/mxser.c
> @@ -1768,7 +1768,7 @@ static int mxser_ioctl(struct tty_struct *tty, struct file *file,
>   		int len, lsr;
>
>   		len = mxser_chars_in_buffer(tty);
> -		spin_lock(&info->slock);
> +		spin_lock_irq(&info->slock);

Hmm, and there is one more error in the MOXA_ASPP_MON case. Interrupts 
are not disabled at all there. Could you fix that too?

Thanks.