From: Larry Finger Date: Thu, 01 Apr 2010 18:12:39 -0500 Subject: [PATCH] b43: N-PHY: fix copy&paste typo In-Reply-To: References: <1270156270-7550-2-git-send-email-zajec5@gmail.com> Message-ID: <4BB52867.4080304@lwfinger.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "richardvoigt@gmail.com" Cc: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , linux-wireless@vger.kernel.org, "John W. Linville" , b43-dev@lists.infradead.org, Myhailo Danylenko On 04/01/2010 06:05 PM, richardvoigt at gmail.com wrote: > Does anybody else think all the magic numbers make this code hard to understand? > > 2010/4/1 Rafa? Mi?ecki : >> Reported-by: Myhailo Danylenko >> Signed-off-by: Rafa? Mi?ecki >> --- >> drivers/net/wireless/b43/phy_n.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/net/wireless/b43/phy_n.c b/drivers/net/wireless/b43/phy_n.c >> index 6fd140a..2ae2445 100644 >> --- a/drivers/net/wireless/b43/phy_n.c >> +++ b/drivers/net/wireless/b43/phy_n.c >> @@ -2790,7 +2790,7 @@ static int b43_nphy_cal_tx_iq_lo(struct b43_wldev *dev, >> } >> b43_ntab_write_bulk(dev, B43_NTAB16(15, 88), 4, If you have any idea what the 16-bit N PHY table 15 with offset 88 and length 4 means to the firmware, please be our guest. All those us that do the RE can only decompile the Broadcom driver, and write the specs. Rafal writes the b43 code from that. Larry