Message-ID: <4BC48199.4060600@...1114...> Date: Tue, 13 Apr 2010 16:37:13 +0200 From: David Sommerseth MIME-Version: 1.0 References: <1269951178-30419-1-git-send-email-dazo@...384...> <4BBE3205.1040303@...1114...> <4BC47655.10101@...1114...> In-Reply-To: Subject: Re: [Openvpn-devel] [PATCH] Add comile time settings from ./configure information to --version List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit To: Alon Bar-Lev Cc: openvpn-devel@lists.sourceforge.net -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 13/04/10 15:59, Alon Bar-Lev wrote: >> Alon, with all respect, it is great getting feedbacks to submitted >> > patches, even REVERT suggestions. Could you perhaps share some thoughts >> > about how to solve it, instead of just rejecting it? > I did. > I sent you an example of how we solve it in OpenSC and Suspend. > > http://www.opensc-project.org/opensc/browser/trunk/configure.ac#L613 > > autoconf log was NEVER intended to be used as programming interface, > and is far than being stable. I feel you oversee something. The configure_h.awk script uses config.h, which is included in most of the C files already. The config.log is *only* used for getting the command line of how ./configure was called, via configure_log.awk. To my knowledge, this information is not available anywhere else. If I have overseen this somewhere, then please enlighten me. The config.log is also not used as a programming interface. One static, configure time related line is *extracted* and compiled into the binary. This is extraction of useful debug information for situation where the openvpn-testing code is distributed in binary. If this configure line is not found, an empty string will be the result, so no openvpn features are harmed. With the clean-up patches, it will now also compile without any issues. And to my knowledge config.log does not change after Make begins to compile the source code. kind regards, David Sommerseth -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iEYEARECAAYFAkvEgZQACgkQDC186MBRfrrMXACgjWOB2de9DITHjyoXQJYFEhuk DpoAmwcqCjnPttfxzw9VoNOBv0nknM5g =Ciw2 -----END PGP SIGNATURE-----