From: =?ISO-8859-1?Q?Andr=E9_Weidemann?= Subject: Re: [Qemu-devel] Qemu-KVM 0.12.3 and Multipath -> Assertion Date: Sat, 08 May 2010 11:53:26 +0200 Message-ID: <4BE53496.5090503@web.de> References: <4BDF3F94.1080608@dlh.net> <4BDFDC44.9030808@redhat.com> <4BE00750.6040804@dlh.net> <4BE01120.30608@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Peter Lieven , kvm@vger.kernel.org, qemu-devel@nongnu.org, Christoph Hellwig To: Kevin Wolf Return-path: Received: from fmmailgate02.web.de ([217.72.192.227]:44295 "EHLO fmmailgate02.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752209Ab0EHJxw (ORCPT ); Sat, 8 May 2010 05:53:52 -0400 In-Reply-To: <4BE01120.30608@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Hi Kevin, On 04.05.2010 14:20, Kevin Wolf wrote: > Am 04.05.2010 13:38, schrieb Peter Lieven: >> hi kevin, >> >> i set a breakpint at bmdma_active_if. the first 2 breaks encountered >> when the last path in the multipath >> failed, but the assertion was not true. >> when i kicked one path back in the breakpoint was reached again, thi= s >> time leading to an assert. >> the stacktrace is from the point shortly before. >> >> hope this helps. > > Hm, looks like there's something wrong with cancelling requests - > bdrv_aio_cancel might decide that it completes a request (and > consequently calls the callback for it) whereas the IDE emulation > decides that it's done with the request before calling bdrv_aio_cance= l. > > I haven't looked in much detail what this could break, but does > something like this help? Your attached patch fixes the problem I had as well. I ran 3 consecutiv= e=20 tests tonight, which all finished without crashing the VM. I reported my "assertion failed" error on March 14th while doing disk=20 perfomance tests using iozone in an Ubuntu 9.10 VM with qemu-kvm 0.12.3= =2E Thank you very much. Andr=E9