From: Jiri Slaby Subject: Re: [RFC] mm: generic adaptive large memory allocation APIs Date: Thu, 13 May 2010 10:43:39 +0200 Message-ID: <4BEBBBBB.3050201@suse.cz> References: <1273105838-4441-1-git-send-email-xiaosuo@gmail.com> <20100513134124.2164.A69D9226@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Changli Gao , akpm@linux-foundation.org, Eric Dumazet , Alexander Viro , "Paul E. McKenney" , Alexey Dobriyan , Ingo Molnar , Peter Zijlstra , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Avi Kivity , Tetsuo Handa To: KOSAKI Motohiro Return-path: Received: from mail-fx0-f46.google.com ([209.85.161.46]:59126 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753167Ab0EMIno (ORCPT ); Thu, 13 May 2010 04:43:44 -0400 In-Reply-To: <20100513134124.2164.A69D9226@jp.fujitsu.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 05/13/2010 06:45 AM, KOSAKI Motohiro wrote: > Hi > >> void *kvmalloc(size_t size) >> { >> void *ptr; >> >> if (size < PAGE_SIZE) >> return kmalloc(PAGE_SIZE, GFP_KERNEL); >> ptr = alloc_pages_exact(size, GFP_KERNEL | __GFP_NOWARN); > > low order GFP_KERNEL allocation never fail. then, this doesn't works > as you expected. Hi, I suppose you mean the kmalloc allocation -- so kmalloc should fail iff alloc_pages_exact (unless somebody frees a heap of memory indeed)? >> if (ptr != NULL) >> return ptr; >> >> return vmalloc(size); > > On x86, vmalloc area is only 128MB address space. it is very rare > resource than physical ram. vmalloc fallback is not good idea. These functions are a replacement for explicit if (!(x = kmalloc())) x = vmalloc(); ... if (is_vmalloc(x)) vfree(x); else kfree(x); in the code (like fdtable does this). The 128M limit on x86_32 for vmalloc is configurable so if drivers in sum need more on some specific hardware, it can be increased on the command line (I had to do this on one machine in the past). Anyway as this is a replacement for explicit tests, it shouldn't change the behaviour in any way. Obviously when a user doesn't need virtually contiguous space, he shouldn't use this interface at all. thanks, -- js suse labs