From: Jiri Slaby Subject: Re: [RFC] mm: generic adaptive large memory allocation APIs Date: Thu, 13 May 2010 12:16:32 +0200 Message-ID: <4BEBD180.3040404@suse.cz> References: <20100513174512.2179.A69D9226@jp.fujitsu.com> <4BEBC43F.6070407@suse.cz> <20100513182403.217C.A69D9226@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Changli Gao , akpm@linux-foundation.org, Eric Dumazet , Alexander Viro , "Paul E. McKenney" , Alexey Dobriyan , Ingo Molnar , Peter Zijlstra , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Avi Kivity , Tetsuo Handa To: KOSAKI Motohiro Return-path: Received: from fg-out-1718.google.com ([72.14.220.153]:60382 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758509Ab0EMKQf (ORCPT ); Thu, 13 May 2010 06:16:35 -0400 In-Reply-To: <20100513182403.217C.A69D9226@jp.fujitsu.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 05/13/2010 11:40 AM, KOSAKI Motohiro wrote: >>>> Anyway as this is a replacement for explicit tests, it shouldn't change >>>> the behaviour in any way. Obviously when a user doesn't need virtually >>>> contiguous space, he shouldn't use this interface at all. >>> >>> Why can't we make fdtable virtually contiguous free? >> >> This is possible, but the question is why to make the code more complex? > > because it's broken. Well, could you explain what exactly is broken about x = kmalloc(size, GFP_KERNEL); if (!x) x = vmalloc(size); ? Is is that kmalloc doesn't return until is has the memory to return when asking for order(size) <= COSTLY_ORDER? I think this is expected. thanks, -- js suse labs