Received: from [140.186.70.92] (port=37176 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ODGDB-00006I-IU for qemu-devel@nongnu.org; Sat, 15 May 2010 08:11:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1ODGD9-0000Hr-QI for qemu-devel@nongnu.org; Sat, 15 May 2010 08:11:21 -0400 Received: from vsmtp05.dti.ne.jp ([202.216.231.140]:56954) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ODGD9-0000HU-5X for qemu-devel@nongnu.org; Sat, 15 May 2010 08:11:19 -0400 Message-ID: <4BEE8F5D.3040104@juno.dti.ne.jp> Date: Sat, 15 May 2010 21:11:09 +0900 From: Shin-ichiro KAWASAKI MIME-Version: 1.0 References: <4BE61DBD.8060707@juno.dti.ne.jp> <4BE9664D.6060405@juno.dti.ne.jp> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH v2] sh: sm501: add 2D engine support List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: qemu-devel@nongnu.org (2010/05/15 5:44), Blue Swirl wrote: > On 5/11/10, Shin-ichiro KAWASAKI wrote: >> Hello Blue Swirl, and thank you for the review. >> >> Here's the patch modified according to your comments. >> abort() is used instead of assert(), and const modifier added for >> CPU*MemoryFunc. > > The patch does not apply. It seems to be based on some version before > 61d3cf93e2676282ba1a8d568b2406257f208b26. Ah, I've not yet pulled newest one. >> * - Performance tuning >> */ >> @@ -508,6 +508,18 @@ typedef struct SM501State { >> uint32_t dc_crt_hwc_color_1_2; >> uint32_t dc_crt_hwc_color_3; >> + uint32_t _2d_destination; >> + uint32_t _2d_dimension; >> + uint32_t _2d_control; >> + uint32_t _2d_pitch; >> + uint32_t _2d_foreground; >> + uint32_t _2d_stretch; >> + uint32_t _2d_color_compare_mask; >> + uint32_t _2d_mask; >> + uint32_t _2d_window_width; >> + uint32_t _2d_source_base; >> + uint32_t _2d_destination_base; > > While at it, could you remove the underscore prefix from the field names? > OK. I'll rename them, from _2d_* into twoD_*. Thank you for the review. Best Regards, Shin-ichiro KAWASAKI