From: augulis.darius@gmail.com (Darius Augulis)
Date: Fri, 18 Jun 2010 21:30:46 +0300
Subject: [PATCH 11/15] ARM: S3C2416: Add support for second HSMMC channel
In-Reply-To: <20100617191901.GA5864@jeknote.loshitsa1.net>
References: <1273631766-15693-1-git-send-email-ben-linux@fluff.org>
	<1273631766-15693-11-git-send-email-ben-linux@fluff.org>
	<4C1A71F6.5030203@gmail.com>
	<20100617191901.GA5864@jeknote.loshitsa1.net>
Message-ID: <4C1BBB56.4090205@gmail.com>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

On 06/17/2010 10:19 PM, Yauhen Kharuzhy wrote:
> On Thu, Jun 17, 2010 at 10:05:26PM +0300, Darius Augulis wrote:
>> On 05/12/2010 05:36 AM, Ben Dooks wrote:
>>> Add support for the second HSMMC channel on the S3C2416.
>>
>> There is issue with mach-s3c2416 and sdhci-s3c driver.
>> Driver probe crashes with following backtrace:
>>
>> sdhci: Secure Digital Host Controller Interface driver
>> sdhci: Copyright(c) Pierre Ossman
>> Unable to handle kernel NULL pointer dereference at virtual address 00000000
>> pgd = c0004000
>> [00000000] *pgd=00000000
>> Internal error: Oops: 5 [#1]
>> last sysfs file:
>> CPU: 0    Not tainted  (2.6.35-rc3-00001-g7dfb002 #31)
>> PC is at sdhci_s3c_probe+0x188/0x42c
>> LR is at clk_enable+0x50/0x60
>>
>> The reason is not completely initialised s3c_sdhci_platdata
>> structure. When getting clocks in sdhci_s3c_probe():
>>
>> for (clks = 0, ptr = 0; ptr<  MAX_BUS_CLK; ptr++) {
>>                  struct clk *clk;
>>                  char *name = pdata->clocks[ptr];
>>
>> Pointer clocks is not initialised at all, because mach-s3c2416
>> doesn't have such helpers like mach-s3c64xx does:
>>
>> s3c6400_default_sdhci0()
>> s3c6400_default_sdhci1()
>> s3c6400_default_sdhci2()
>>
>> Also other necessary s3c_sdhci_platdata members cfg_gpio and
>> cfg_card are missing on s3c2416.
>>
>> Is there any patch adding this missing info to mach-s3c2416?
>
> I am already wrote such patch today and will post it after testing
> tomorrow, I hope.

Hi Yauhen,

could you please send me this patch? I will test it too by my side.
thanks.


>