From: sshtylyov@mvista.com (Sergei Shtylyov) Date: Tue, 06 Jul 2010 14:44:38 +0400 Subject: [PATCH] ARM: S5PV210: Fix on SECTION_SIZE_BITS on S5PV210/S5PC110. In-Reply-To: <1278391007-11144-1-git-send-email-kgene.kim@samsung.com> References: <1278391007-11144-1-git-send-email-kgene.kim@samsung.com> Message-ID: <4C330916.1070201@ru.mvista.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello. Kukjin Kim wrote: > This patch fixes on SECTION_SIZE_BITS for Sparsemem on S5PV210/S5PC110. > Because smallest size of a bank on S5PV210/S5PC110 is aligned by 16MB. > So each section's maximum size should be 16MB. > Reported-by: Kyongho Cho > Signed-off-by: Kukjin Kim > --- > arch/arm/mach-s5pv210/include/mach/memory.h | 8 ++++++-- > 1 files changed, 6 insertions(+), 2 deletions(-) > diff --git a/arch/arm/mach-s5pv210/include/mach/memory.h b/arch/arm/mach-s5pv210/include/mach/memory.h > index 379117e..4a372d8 100644 > --- a/arch/arm/mach-s5pv210/include/mach/memory.h > +++ b/arch/arm/mach-s5pv210/include/mach/memory.h > @@ -16,8 +16,12 @@ > #define PHYS_OFFSET UL(0x20000000) > #define CONSISTENT_DMA_SIZE (SZ_8M + SZ_4M + SZ_2M) > > -/* Maximum of 256MiB in one bank */ > +/* Sparsemem support. Each section is a maximum of 16MB. > + * Because there are many different memory type on S5PC110(MCP), > + * and there is a case that having 80MB, 128MB or 256MB in one > + * bank. > +*/ According to CodingStyle, the prefrerrable format for multi-line comments is this: /* * bla * bla */ WBR, Sergei