DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=message-id:date:from:user-agent:mime-version:to:subject:references
	:in-reply-to:x-enigmail-version:content-type;
	b=RoRg8srxnVIuR8XIFaaITi1Rk8vxYqQwNchcWUn+j2VcRetVltRshd6PmjbyqSBiM9
	WUrm50dDwLpkxPm6cw57O7H5aux5BHsvtlur6B1sxOdBVSdbO97hGNDNV6v2orKxod0W
	mlfVWZSRBIC/GqoTmmuXCA99XRlhA3LkKOCTw=
Message-ID: <4C33718B.1030109@gmail.com>
Date: Tue, 06 Jul 2010 20:10:19 +0200
From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?=
	<phcoder@gmail.com>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US;
	rv:1.9.1.10) Gecko/20100620 Icedove/3.0.5
MIME-Version: 1.0
To: grub-devel@gnu.org
References: <20100706165253.GP21862@riva.ucam.org>
In-Reply-To: <20100706165253.GP21862@riva.ucam.org>
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature";
	boundary="------------enigAF55DEEF4B28C6FA1196AD0F"
Subject: Re: [PATCH] Add raid5rec and raid6rec to grub-probe and grub-setup
Precedence: list
Reply-To: The development of GNU GRUB <grub-devel@gnu.org>

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enigAF55DEEF4B28C6FA1196AD0F
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On 07/06/2010 06:52 PM, Colin Watson wrote:
> Martin F. Krafft showed up on IRC with a problem that turned out to be
> mainly due to running on a degraded RAID array, which grub-probe and
> grub-setup were unable to handle because they didn't have the necessary=

> modules built in.  (He has some other problem after that which I haven'=
t
> yet managed to track down.)
>
> Is there any reason not to include RAID recovery support in grub-probe
> and grub-setup?  It's already in grub-fstest, including it at least
> makes GRUB installable for Martin, and I don't see any commits that
> explicitly removed this support at any point so there doesn't seem to b=
e
> any particular reason they aren't included.
>
>  =20
Go ahead for mainline
> 2010-07-06  Colin Watson  <cjwatson@ubuntu.com>
>
> 	* conf/common.rmk (grub_probe_SOURCES): Add disk/raid5_recover.c
> 	and disk/raid6_recover.c.
> 	* conf/i386-pc.rmk (grub_setup_SOURCES): Likewise.
> 	* conf/sparc64-ieee1275.rmk (grub_setup_SOURCES): Likewise.
>
> =3D=3D=3D modified file 'conf/common.rmk'
> --- conf/common.rmk	2010-07-02 17:35:07 +0000
> +++ conf/common.rmk	2010-07-06 14:03:50 +0000
> @@ -38,7 +38,8 @@ grub_probe_SOURCES =3D gnulib/progname.c u
>  	partmap/msdos.c partmap/bsdlabel.c partmap/apple.c \
>  	partmap/sun.c partmap/sunpc.c partmap/gpt.c \
>  	kern/fs.c kern/env.c fs/fshelp.c			\
> -	disk/raid.c disk/mdraid_linux.c disk/lvm.c grub_probe_init.c
> +	disk/raid.c disk/raid5_recover.c disk/raid6_recover.c	\
> +	disk/mdraid_linux.c disk/lvm.c grub_probe_init.c
> =20
>  ifeq ($(enable_grub_fstest), yes)
>  bin_UTILITIES +=3D grub-fstest
>
> =3D=3D=3D modified file 'conf/i386-pc.rmk'
> --- conf/i386-pc.rmk	2010-06-12 11:17:28 +0000
> +++ conf/i386-pc.rmk	2010-07-06 14:04:13 +0000
> @@ -78,7 +78,8 @@ grub_setup_SOURCES =3D gnulib/progname.c u
>  	partmap/msdos.c partmap/bsdlabel.c partmap/sunpc.c		\
>  	partmap/gpt.c							\
>  									\
> -	disk/raid.c disk/mdraid_linux.c disk/lvm.c			\
> +	disk/raid.c disk/raid5_recover.c disk/raid6_recover.c		\
> +	disk/mdraid_linux.c disk/lvm.c					\
>  	util/raid.c util/lvm.c						\
>  	grub_setup_init.c
> =20
>
> =3D=3D=3D modified file 'conf/sparc64-ieee1275.rmk'
> --- conf/sparc64-ieee1275.rmk	2010-07-02 17:35:07 +0000
> +++ conf/sparc64-ieee1275.rmk	2010-07-06 14:04:29 +0000
> @@ -62,7 +62,8 @@ grub_setup_SOURCES =3D util/sparc64/ieee12
>  	partmap/amiga.c	partmap/apple.c partmap/msdos.c			\
>  	partmap/bsdlabel.c partmap/sun.c partmap/acorn.c		\
>  									\
> -	disk/raid.c disk/mdraid_linux.c disk/lvm.c util/raid.c		\
> +	disk/raid.c disk/raid5_recover.c disk/raid6_recover.c		\
> +	disk/mdraid_linux.c disk/lvm.c util/raid.c			\
>  	util/lvm.c gnulib/progname.c grub_setup_init.c
> =20
>  # For grub-ofpathname.
>
> Thanks,
>
>  =20


--=20
Regards
Vladimir '=CF=86-coder/phcoder' Serbinenko


--------------enigAF55DEEF4B28C6FA1196AD0F
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iF4EAREKAAYFAkwzcYsACgkQNak7dOguQgnbJwEAuvuKwlA2JnBh/lQnPwh/kJXI
wsjmSfWsYvr9/fo4OJ4BAL8fqrZ+cX6CdY+amQ95n7x+ISPDIkgXS7fTS8fMeWjT
=mUcr
-----END PGP SIGNATURE-----

--------------enigAF55DEEF4B28C6FA1196AD0F--