From: Phillip Lougher Subject: Re: Q. cache in squashfs? Date: Fri, 09 Jul 2010 11:55:19 +0100 Message-ID: <4C370017.4070604@lougher.demon.co.uk> References: <19486.1277347066@jrobl> <4C354CBE.70401@lougher.demon.co.uk> <6356.1278569327@jrobl> <15323.1278662033@jrobl> <4C36FAB1.6010506@lougher.demon.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Phillip Lougher , linux-fsdevel@vger.kernel.org To: "J. R. Okajima" Return-path: Received: from anchor-post-1.mail.demon.net ([195.173.77.132]:55787 "EHLO anchor-post-1.mail.demon.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753817Ab0GILA3 (ORCPT ); Fri, 9 Jul 2010 07:00:29 -0400 In-Reply-To: <4C36FAB1.6010506@lougher.demon.co.uk> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Phillip Lougher wrote: > > That was discussed on this list back in 2008, and there are pros and cons > to doing this. You can look at the list archives for the discussion and > so I won't repeat it here. At the moment I see this as a red herring > because your results suggest something more fundamental is wrong. Doing > what you did above with the size of the read_page cache should not have > made any difference, and if it did, it suggests pages which *should* be > in the page cache (explicitly pushed there by the read_page() routine) are > not there. In short its not a question of should Squashfs be using the > page cache, for the pages in question it already is. > > I'll try and reproduce your results, as they're to be frank > significantly at variance to my previous experience. Maybe there's a bug > or VFS changes means the page pushing into the page cache isn't working, > but I cannot see where your repeated block reading/decompression results are > coming from. > You can determine which blocks are being repeatedly decompressed by printing out the value of cache->name in squashfs_cache_get(). You should get one of "data", "fragment" and "metadata" for data blocks, fragment blocks and metadata respectively. This information will go a long way in showing where the problem lies. Phillip