From: Rogan Dawes Date: Tue, 13 Jul 2010 13:44:25 +0200 Subject: [U-Boot] [PATCH V4 2/4] ide: add mvsata_ide driver In-Reply-To: <1279021246-11477-2-git-send-email-albert.aribaud@free.fr> References: <1279021246-11477-1-git-send-email-albert.aribaud@free.fr> <1279021246-11477-2-git-send-email-albert.aribaud@free.fr> Message-ID: <4C3C5199.1030309@dawes.za.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 2010/07/13 1:40 PM, Albert Aribaud wrote: > +/* Mask and values for device Interface Power Management */ > +#define MVSATA_SCONTROL_IMP_MASK 0x00000F00 > +#define MVSATA_SCONTROL_IMP_NO_LP_ALLOWED 0x00000300 Should this not then be: +#define MVSATA_SCONTROL_IPM_MASK 0x00000F00 +#define MVSATA_SCONTROL_IPM_NO_LP_ALLOWED 0x00000300 ? IPM vs IMP Rogan