From: Juergen Gross Subject: [Patch] libxl: fix memory leak in libxl_name_to_poolid Date: Thu, 05 Aug 2010 10:55:21 +0200 Message-ID: <4C5A7C79.2090006@ts.fujitsu.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------060604050603090907010703" Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org This is a multi-part message in MIME format. --------------060604050603090907010703 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Hi, attached patch is similar to cs 21908, just other function... Juergen -- Juergen Gross Principal Developer Operating Systems TSP ES&S SWE OS6 Telephone: +49 (0) 89 3222 2967 Fujitsu Technology Solutions e-mail: juergen.gross@ts.fujitsu.com Domagkstr. 28 Internet: ts.fujitsu.com D-80807 Muenchen Company details: ts.fujitsu.com/imprint.html --------------060604050603090907010703 Content-Type: text/x-patch; name="memleak.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="memleak.patch" Signed-off-by: juergen.gross@ts.fujitsu.com diff -r 8992134dcfd0 tools/libxl/libxl_utils.c --- a/tools/libxl/libxl_utils.c Wed Aug 04 19:24:17 2010 +0100 +++ b/tools/libxl/libxl_utils.c Thu Aug 05 10:50:34 2010 +0200 @@ -101,6 +101,7 @@ int libxl_name_to_poolid(libxl_ctx *ctx, int i, nb_pools; char *poolname; libxl_poolinfo *poolinfo; + int ret = -1; poolinfo = libxl_list_pool(ctx, &nb_pools); if (!poolinfo) @@ -112,10 +113,12 @@ int libxl_name_to_poolid(libxl_ctx *ctx, continue; if (strcmp(poolname, name) == 0) { *poolid = poolinfo[i].poolid; - return 0; + ret = 0; + break; } } - return -1; + free(poolinfo); + return ret; } int libxl_get_stubdom_id(libxl_ctx *ctx, int guest_domid) --------------060604050603090907010703 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --------------060604050603090907010703--