From: Albert ARIBAUD Date: Fri, 20 Aug 2010 08:48:51 +0200 Subject: [U-Boot] [PATCH] Align linebuf to avoid misaligned aliases of it In-Reply-To: <201008190159.00585.vapier@gentoo.org> References: <1281773473-5697-1-git-send-email-albert.aribaud@free.fr> <4C6C4457.3070504@free.fr> <201008190159.00585.vapier@gentoo.org> Message-ID: <4C6E2553.8000001@free.fr> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Le 19/08/2010 07:58, Mike Frysinger a ?crit : > On Wednesday, August 18, 2010 16:36:39 Albert ARIBAUD wrote: >> Le 18/08/2010 19:54, Mike Frysinger a ?crit : >>> On Wed, Aug 18, 2010 at 1:46 PM, Albert ARIBAUD wrote: >>>> Le 18/08/2010 18:46, Mike Frysinger a ?crit : >>>>> you need to include linux/compiler.h first ... but i would have >>>>> thought this be a header already included globally. maybe that's a >>>>> new topic to start. >>>> >>>> I don't understand why I should introduce a dependency on linux. What is >>>> the benefit? >>> >>> u-boot already includes the header in the source tree, not to mention >>> the fact that this file is already including linux/ctype.h >> >> But absolutely no .h or .c file uses __aligned whereas >> __attribute__((__aligned__())) is used in several places, right? > > that would seem to be the case currently > -mike In that case, I'll stick with the currently used syntax for this patch. If someone feels the need to switch over to __aligned, I think issuing a separate global patch which changes all occurrences makes more sense than using both forms in the source code. Amicalement, -- Albert.