From: Reinhard Meyer Date: Sun, 29 Aug 2010 00:23:18 +0200 Subject: [U-Boot] [PATCH v2] MTD/SPI/FLASH: add support for Ramtron FRAMs using SPI In-Reply-To: <201008281749.41507.vapier@gentoo.org> References: <1282907797-21428-1-git-send-email-u-boot@emk-elektronik.de> <201008281749.41507.vapier@gentoo.org> Message-ID: <4C798C56.7070202@emk-elektronik.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Mike Frysinger, > On Friday, August 27, 2010 07:16:37 Reinhard Meyer wrote: >> From: Reinhard Meyer >> >> Signed-off-by: Reinhard Meyer > > looks like you still need to do `git commit --amend --author 'Reinhard Meyer > '` ... Both are valid e-mail addresses, who says the one who signs off and the one who sends the e-mail must be the same person? Its tedious to change that because its like 10 commits back in my branch. But I can do that again. > >> +#ifdef CONFIG_SPI_FRAM_RAMTRON_NONSTD > > i would stick with the style "NON_JEDEC" Doable. Is there anything else within the patch itself that you deem need to be changed? Reinhard