Received: from [140.186.70.92] (port=54919 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OvDYt-0008J5-EE for qemu-devel@nongnu.org; Mon, 13 Sep 2010 14:15:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OvDYi-0005nc-Fl for qemu-devel@nongnu.org; Mon, 13 Sep 2010 14:15:17 -0400 Received: from moutng.kundenserver.de ([212.227.126.171]:51750) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OvDYi-0005nP-3o for qemu-devel@nongnu.org; Mon, 13 Sep 2010 14:15:16 -0400 Message-ID: <4C8E6A2F.1050602@mail.berlios.de> Date: Mon, 13 Sep 2010 20:15:11 +0200 From: Stefan Weil MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] trace: Fix user emulator dependency on trace objects References: <1284304896-3239-1-git-send-email-andreas.faerber@web.de> In-Reply-To: <1284304896-3239-1-git-send-email-andreas.faerber@web.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Cc: qemu-devel@nongnu.org Am 12.09.2010 17:21, schrieb Andreas Färber: > On a clean build, after generating trace.h, make would recurse into > *-*-user > without a clue how to build ../trace.o (added to $(obj-y) in > Makefile.target) > since its generation rule is in the main Makefile. > The softmmus are seemingly unaffected because the $(TOOLS), which each > have > a dependency on $(trace-obj-y), are built first for the build-all target. > > Add a dependency on $(trace-obj-y) for %-user, as done for the qemu-* > tools. > > Let's be paranoid and do the same for %-softmmu while at it, just in case > someone messes with $(TOOLS) or calls the Makefile target directly. > > Signed-off-by: Andreas Färber > Cc: Stefan Hajnoczi > Cc: Prerna Saxena > Cc: Blue Swirl > Cc: Anthony Liguori > --- > Makefile | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Makefile b/Makefile > index ab91d42..090d632 100644 > --- a/Makefile > +++ b/Makefile > @@ -80,9 +80,9 @@ include $(SRC_PATH)/Makefile.objs > endif > > $(common-obj-y): $(GENERATED_HEADERS) > -$(filter %-softmmu,$(SUBDIR_RULES)): $(common-obj-y) subdir-libdis > +$(filter %-softmmu,$(SUBDIR_RULES)): $(trace-obj-y) $(common-obj-y) > subdir-libdis > > -$(filter %-user,$(SUBDIR_RULES)): $(GENERATED_HEADERS) > subdir-libdis-user subdir-libuser > +$(filter %-user,$(SUBDIR_RULES)): $(GENERATED_HEADERS) $(trace-obj-y) > subdir-libdis-user subdir-libuser > > ROMSUBDIR_RULES=$(patsubst %,romsubdir-%, $(ROMS)) > romsubdir-%: Acked-by: Stefan Weil Doing the same for %-softmmu was a good idea and helped me, thanks. Stefan