From: Alexander Graf Subject: Re: [PATCH 3/3] Add svm cpuid features Date: Thu, 16 Sep 2010 16:17:09 +0200 Message-ID: <4C9226E5.4080906@suse.de> References: <1284479530-4748-1-git-send-email-joerg.roedel@amd.com> <1284479530-4748-4-git-send-email-joerg.roedel@amd.com> <4C922478.7010703@redhat.com> <20100916141259.GA7972@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Avi Kivity , Marcelo Tosatti , "kvm@vger.kernel.org" , "qemu-devel@nongnu.org" To: "Roedel, Joerg" Return-path: Received: from cantor2.suse.de ([195.135.220.15]:43170 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752245Ab0IPORL (ORCPT ); Thu, 16 Sep 2010 10:17:11 -0400 In-Reply-To: <20100916141259.GA7972@amd.com> Sender: kvm-owner@vger.kernel.org List-ID: Roedel, Joerg wrote: > On Thu, Sep 16, 2010 at 10:06:48AM -0400, Avi Kivity wrote: > >> On 09/14/2010 05:52 PM, Joerg Roedel wrote: >> >>> This patch adds the svm cpuid feature flags to the qemu >>> intialization path. It also adds the svm features available >>> on phenom to its cpu-definition and extends the host cpu >>> type to support all svm features KVM can provide. >>> >>> >>> >> Does phenom really have vmcbclean? I thought it was a really new feature. >> > > No, but we could emulate it on almost all hardware that has SVM. Its > basically the same as with x2apic. > -cpu is not about what we could emulate, but what the hardware really is. Features not supported by the particular CPU do not belong there. Alex