From: Avi Kivity Subject: Re: [PATCH RFC] kvm: enable irq injection from interrupt context Date: Sun, 19 Sep 2010 12:56:12 +0200 Message-ID: <4C95EC4C.4060904@redhat.com> References: <20100916125717.GA24284@redhat.com> <20100916131823.GH3008@redhat.com> <20100916135137.GB24850@redhat.com> <20100916140615.GJ3008@redhat.com> <20100916142335.GC24850@redhat.com> <20100916145117.GK3008@redhat.com> <20100916152411.GE24850@redhat.com> <20100916154326.GL3008@redhat.com> <20100916220715.GA30531@redhat.com> <20100917075929.GA11518@redhat.com> <20100919104550.GA7350@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Gleb Natapov , Marcelo Tosatti , kvm@vger.kernel.org, linux-kernel@vger.kernel.org To: "Michael S. Tsirkin" Return-path: In-Reply-To: <20100919104550.GA7350@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 09/19/2010 12:45 PM, Michael S. Tsirkin wrote: > On Fri, Sep 17, 2010 at 09:59:29AM +0200, Gleb Natapov wrote: > > > writing 0 to eventfd does nothing. The way to deassert irq > > That is implementation detail of current irqfd. It was designed for MSI > > not level triggered interrupts. > > Maybe we should add a check that gsi is mapped to MSI (or unmapped) then? > Level which switches to 1 and back to 0 immediately will be racy anyway > ... > Add a check where? -- error compiling committee.c: too many arguments to function