Received: from [140.186.70.92] (port=57170 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P11yy-000738-Kg for qemu-devel@nongnu.org; Wed, 29 Sep 2010 15:06:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1P11yx-00053Z-0X for qemu-devel@nongnu.org; Wed, 29 Sep 2010 15:06:24 -0400 Received: from out-76.smtp.ucla.edu ([169.232.46.169]:53623) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P11yw-00052n-Hf for qemu-devel@nongnu.org; Wed, 29 Sep 2010 15:06:22 -0400 Received: from mail.ucla.edu (mail.ucla.edu [169.232.48.151]) by smtp-15.smtp.ucla.edu (8.14.3/8.14.3) with ESMTP id o8TJ5mFf006009 for ; Wed, 29 Sep 2010 12:05:48 -0700 Received: from [131.179.32.130] (Cs-32-130.CS.UCLA.EDU [131.179.32.130]) (authenticated bits=0) by mail.ucla.edu (8.14.4/8.14.4) with ESMTP id o8TJ5lWA016598 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT) for ; Wed, 29 Sep 2010 12:05:48 -0700 Message-ID: <4CA38E0B.5090504@cs.ucla.edu> Date: Wed, 29 Sep 2010 12:05:47 -0700 From: Eddie Kohler MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] [PATCH] Reverse VNC connections: Avoid segmentation fault. List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Hi -vnc HOST:PORT,reverse connections are currently broken, because vnc_refresh_server_surface is called before the guest is actually available. The following patch fixes reverse connections. Eddie >From 32fe1bc61ee9f2f1a8220642a48acb05b5be7322 Mon Sep 17 00:00:00 2001 From: Eddie Kohler Date: Wed, 29 Sep 2010 12:00:55 -0700 Subject: [PATCH] Reverse VNC connections: Avoid segmentation fault. --- ui/vnc.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index c7a1831..8c3af8a 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -2261,6 +2261,10 @@ static int vnc_refresh_server_surface(VncDisplay *vd) VncState *vs; int has_dirty = 0; + /* On reverse connections, the guest might not be connected yet. */ + if (!vd->guest.ds) + return 0; + /* * Walk through the guest dirty map. * Check and copy modified bits from guest to server surface. -- 1.7.0.4