From: Felix Fietkau Date: Sat, 16 Oct 2010 00:11:32 +0200 Subject: [ath9k-devel] [PATCH v2] ath9k: Properly initialize ath_common->cc_lock. In-Reply-To: <1287180249-18647-1-git-send-email-greearb@candelatech.com> References: <1287180249-18647-1-git-send-email-greearb@candelatech.com> Message-ID: <4CB8D194.9060907@openwrt.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ath9k-devel@lists.ath9k.org On 2010-10-16 12:04 AM, greearb at candelatech.com wrote: > From: Ben Greear > > Otherwise, lockdep splats, at the least: > [...] > diff --git a/drivers/net/wireless/ath/ath9k/init.c b/drivers/net/wireless/ath/ath9k/init.c > index a4c5ed4..fdc25f9 100644 > --- a/drivers/net/wireless/ath/ath9k/init.c > +++ b/drivers/net/wireless/ath/ath9k/init.c > @@ -577,6 +577,7 @@ static int ath9k_init_softc(u16 devid, struct ath_softc *sc, u16 subsysid, > common->hw = sc->hw; > common->priv = sc; > common->debug_mask = ath9k_debug; > + spin_lock_init(&common->cc_lock); > > spin_lock_init(&sc->wiphy_lock); > spin_lock_init(&sc->sc_resetlock); Makes sense. Please update ath5k as well, it also uses the lock. - Felix