Return-path: Received: from mail-ww0-f44.google.com ([74.125.82.44]:41445 "EHLO mail-ww0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757088Ab0JVUHz (ORCPT ); Fri, 22 Oct 2010 16:07:55 -0400 Received: by wwe15 with SMTP id 15so1285987wwe.1 for ; Fri, 22 Oct 2010 13:07:54 -0700 (PDT) Message-ID: <4CC1EF20.5030506@lwfinger.net> Date: Fri, 22 Oct 2010 15:08:00 -0500 From: Larry Finger MIME-Version: 1.0 To: =?UTF-8?B?R8OhYm9yIFN0ZWZhbmlr?= CC: b43-dev , linux-wireless@vger.kernel.org, "John W. Linville" Subject: Re: [PATCH 3/5] b43: define known SPROM boardflags2 bits References: <1287762229-16516-2-git-send-email-zajec5@gmail.com> <1287762229-16516-4-git-send-email-zajec5@gmail.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 10/22/2010 02:41 PM, Gábor Stefanik wrote: > 2010/10/22 Rafał Miłecki : >> Signed-off-by: Rafał Miłecki >> --- >> drivers/net/wireless/b43/b43.h | 13 +++++++++++++ >> 1 files changed, 13 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/net/wireless/b43/b43.h b/drivers/net/wireless/b43/b43.h >> index 72821c4..9aad2ca 100644 >> --- a/drivers/net/wireless/b43/b43.h >> +++ b/drivers/net/wireless/b43/b43.h >> @@ -153,6 +153,19 @@ >> #define B43_BFH_FEM_BT 0x0040 /* has FEM and switch to share antenna >> * with bluetooth */ >> >> +/* SPROM boardflags2_lo values */ >> +#define B43_BFL2_RXBB_INT_REG_DIS 0x0001 /* external RX BB regulator present */ >> +#define B43_BFL2_APLL_WAR 0x0002 /* alternative A-band PLL settings implemented */ >> +#define B43_BFL2_TXPWRCTRL_EN 0x0004 /* permits enabling TX Power Control */ >> +#define B43_BFL2_2X4_DIV 0x0008 /* 2x4 diversity switch */ >> +#define B43_BFL2_5G_PWRGAIN 0x0010 /* supports 5G band power gain */ >> +#define B43_BFL2_PCIEWAR_OVR 0x0020 /* overrides ASPM and Clkreq settings */ >> +#define B43_BFL2_CAESERS_BRD 0x0040 /* is Caesers board (unused) */ > > I'm almost sure this is a typo in the specs. > > Larry? Nope - it is Cae..., not Cea.... Whatever name we use is just a placeholder as that bit is never used. Larry