From: Reinhard Meyer Date: Mon, 25 Oct 2010 22:28:21 +0200 Subject: [U-Boot] ALERT! >90% of all board configurations BROKEN In-Reply-To: <20101025200019.B5BBC152451@gemini.denx.de> References: <20101025200019.B5BBC152451@gemini.denx.de> Message-ID: <4CC5E865.70003@emk-elektronik.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Wolfgang Denk, > this is an ALERT! > > I just noticed (when debugging a strage phenomenon) that most of the > board configurations (170 out of 191 for PowerPC, _ALL_ for ARM) are > broken, because the size of struct global_data has grown but > CONFIG_SYS_GBL_DATA_SIZE has not been adapted (commit 91a7675 added > 32 bytes - and yes, I am to blame for that, where is that brown paper > bag...) > > Fact is, the overwhelming majority of boards has currently problems > like this: > > sizeof(struct global_data) = 136, CONFIG_SYS_GBL_DATA_SIZE = 128 > > > This may appear to work, or may cause "funny" errors, or simply hangs > the board hard very early in booting. Grep-ing for CONFIG_SYS_GBL_DATA_SIZE in *.[chsS] Makefile *.ld it seems to me that with "ELF-reloc" active that define is not used anywhere at least in ARM. Or did I miss a place? Best Regards, Reinhard