From: Reinhard Meyer Date: Tue, 26 Oct 2010 11:04:18 +0200 Subject: [U-Boot] [PATCH 1/2] mx51evk: support new relocation scheme In-Reply-To: References: <1288019681-18496-1-git-send-email-shawn.gsc@gmail.com> <1288019681-18496-2-git-send-email-shawn.gsc@gmail.com> <4CC68A6B.1030302@denx.de> <4CC68DD6.6030506@denx.de> <4CC69072.9010403@denx.de> <4CC692A9.2080800@denx.de> Message-ID: <4CC69992.1060505@emk-elektronik.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Shawn Guo, > On Tue, Oct 26, 2010 at 4:34 PM, Stefano Babic wrote: >> On 10/26/2010 10:25 AM, Heiko Schocher wrote: >>> We should set the CONFIG_SYS_INIT_SP_ADDR @ (IRAM_BASE_ADDR + IRAM_BASE_SIZE >>> - CONFIG_SYS_GBL_DATA_SIZE) >> Agree, this is what I set for the vision2 board. We should be consistent >> and do the same for the mx51evk. >> >>> Don;t know if IRAM_BASE_SIZE exists ... >> we must define it. I set it in the board configuration file, but it is >> wrong. The value should be moved into register definition file for the >> SoC (imx-regs.h) >> > I see many other platforms using 0x1000 offset way to define > CONFIG_SYS_INIT_SP_ADDR, so I did that to make it a little bit more > common. But I'm fine to start from the end, and will send v3 of this > patch soon. I just tried to add the symbolic version #define CONFIG_SYS_INIT_SP_ADDR (xxx_SRAM_BASE + xxx_SRAM_SIZE - CONFIG_SYS_GBL_DATA_SIZE) in AT91, but that means (assuming those xxx- defines come from an SoC specific file) that in start.s the includes #if defined(CONFIG_OMAP1610) #include <./configs/omap1510.h> #elif defined(CONFIG_OMAP730) #include <./configs/omap730.h> #endif have to be expanded for every SoC in question. Or to include the .h into the .h... Which way to go? Reinhard