From: Reinhard Meyer Date: Wed, 27 Oct 2010 16:43:46 +0200 Subject: [U-Boot] [PATCH V3] imx25: Fix reset In-Reply-To: <1288190078-2770-1-git-send-email-weisserm@arcor.de> References: <1288190078-2770-1-git-send-email-weisserm@arcor.de> Message-ID: <4CC83AA2.2070900@emk-elektronik.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Matthias Weisser, > struct wdog_regs { > - u32 wcr; /* Control */ > - u32 wsr; /* Service */ > - u32 wrsr; /* Reset Status */ > - u32 wicr; /* Interrupt Control */ > - u32 wmcr; /* Misc Control */ > + u16 wcr; /* Control */ > + u16 wsr; /* Service */ > + u16 wrsr; /* Reset Status */ > + u16 wicr; /* Interrupt Control */ > + u16 wmcr; /* Misc Control */ > }; What catches my ARM-aware eye: I do not know the hardware, but are those registers really arranged on 2 byte boundaries (00, 02, 04, 06, 08, 0a, .. offsets)? Probably yes, assuming your code is tested ;) Or should there be a u16 filler between each register? Best Regards, Reinhard