From: Reinhard Meyer Date: Thu, 28 Oct 2010 22:52:55 +0200 Subject: [U-Boot] [PATCH RFC 0/3] ARM Relocation Config Cleanup In-Reply-To: <1288293126-24949-1-git-send-email-wd@denx.de> References: <1288293126-24949-1-git-send-email-wd@denx.de> Message-ID: <4CC9E2A7.3080506@emk-elektronik.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Wolfgang Denk, > Wolfgang Denk (3): > Replace CONFIG_RELOC_FIXUP_WORKS by CONFIG_BROKEN_RELOC_FIXUP Seems a slight misnomer to me, and a bit hides what it really does. What about CONFIG_NEEDS_DATA_RELOC_FIXUP ? > arch/arm/cpu/arm1136/start.S | 131 ---------------- > arch/arm/cpu/arm1176/start.S | 218 -------------------------- > arch/arm/cpu/arm720t/start.S | 107 ------------- > arch/arm/cpu/arm920t/start.S | 146 ------------------ > arch/arm/cpu/arm925t/start.S | 123 --------------- > arch/arm/cpu/arm926ejs/orion5x/dram.c | 15 -- > arch/arm/cpu/arm926ejs/start.S | 100 ------------ > arch/arm/cpu/arm946es/start.S | 87 ----------- > arch/arm/cpu/arm_intcm/start.S | 89 ----------- > arch/arm/cpu/armv7/omap3/emif4.c | 24 --- > arch/arm/cpu/armv7/omap3/sdrc.c | 28 ---- > arch/arm/cpu/armv7/omap4/board.c | 5 - > arch/arm/cpu/armv7/start.S | 117 -------------- > arch/arm/cpu/ixp/start.S | 205 ------------------------- > arch/arm/cpu/lh7a40x/start.S | 115 -------------- > arch/arm/cpu/pxa/start.S | 32 +--- > arch/arm/cpu/s3c44b0/start.S | 87 ----------- > arch/arm/cpu/sa1100/start.S | 90 ----------- Maybe for a future patch series: Move all not ARM variant/not SoC specific parts (setting up stack, calling C functions, relocation and relocation fixup) to a common file (arch/arm/lib/generic_start.S), basically leaving only specific parts in the various arch/arm/cpu/*/start.S files. This would highly ease maintenance. Best Regards, Reinhard