From: Thomas Hellstrom Subject: Re: [PATCH 1/4] drivers/gpu/drm/vmwgfx: Fix k.alloc switched arguments Date: Mon, 01 Nov 2010 23:00:03 +0100 Message-ID: <4CCF3863.9040500@shipmail.org> References: <1bb253bedd9345e3457ce699f9fbc6f65844738f.1288555098.git.joe@perches.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from smtp-outbound-2.vmware.com (smtp-outbound-2.vmware.com [65.115.85.73]) by gabe.freedesktop.org (Postfix) with ESMTP id BCB579F372 for ; Mon, 1 Nov 2010 15:00:15 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Matt Turner Cc: Joe Perches , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On 11/01/2010 12:52 AM, Matt Turner wrote: > On Sun, Oct 31, 2010 at 6:33 PM, Joe Perches wrote: > >> Signed-off-by: Joe Perches >> --- >> drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c | 2 +- >> drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c b/drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c >> index a01c47d..29113c9 100644 >> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c >> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c >> @@ -557,7 +557,7 @@ int vmw_kms_init_legacy_display_system(struct vmw_private *dev_priv) >> return -EINVAL; >> } >> >> - dev_priv->ldu_priv = kmalloc(GFP_KERNEL, sizeof(*dev_priv->ldu_priv)); >> + dev_priv->ldu_priv = kmalloc(sizeof(*dev_priv->ldu_priv), GFP_KERNEL); >> >> if (!dev_priv->ldu_priv) >> return -ENOMEM; >> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c b/drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c >> index df2036e..f1a52f9 100644 >> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c >> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c >> @@ -585,7 +585,7 @@ int vmw_overlay_init(struct vmw_private *dev_priv) >> return -ENOSYS; >> } >> >> - overlay = kmalloc(GFP_KERNEL, sizeof(*overlay)); >> + overlay = kmalloc(sizeof(*overlay), GFP_KERNEL); >> if (!overlay) >> return -ENOMEM; >> >> -- >> 1.7.3.1.g432b3.dirty >> > Oh! That's a bad one. > Indeed. > Reviewed-by: Matt Turner > Reviewed-by: Thomas Hellstrom > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel >