From: Jan Kiszka Subject: Re: -pcidevice broken - fix or remove it? Date: Tue, 02 Nov 2010 15:31:31 +0100 Message-ID: <4CD020C3.1030803@siemens.com> References: <4CCD8CA3.8020807@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: kvm , "Hao\, Xudong" , Hidetoshi Seto , "Daniel P. Berrange" To: Markus Armbruster Return-path: Received: from thoth.sbs.de ([192.35.17.2]:24635 "EHLO thoth.sbs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751713Ab0KBOcA (ORCPT ); Tue, 2 Nov 2010 10:32:00 -0400 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: Am 02.11.2010 14:19, Markus Armbruster wrote: > Jan Kiszka writes: > >> Hi, >> >> looks like the documented way to configure device assignment at qemu-kvm >> level is broken in 0.13 and git head: >> >> # qemu-system-x86_64 -pcidevice host=0:1a.0 >> qemu-system-x86_64: Parameter 'id' expects an identifier >> Identifiers consist of letters, digits, '-', '.', '_', starting with a letter. >> pcidevice argument parse error; please check the help text for usage >> >> "-device pci-assign" works, but only if specify "iommu=0" (otherwise: No >> IOMMU found. Unable to assign device "(null)"). >> >> Fix that legacy qemu-kvm switch or remove it at this chance? No one >> seems to have complained yet. >> >> Jan > > Broken since June. Xudong Hao (cc'ed) reported it then[1], and > Hidetoshi Seto (also cc'ed) attempted to get it patched [2,3]. > > Removing -pcidevice would be fine with me. For what it's worth, it's > not in upstream qemu. > Patch queued. While at it, I wondered if we should kill "pci_add ... host" as well. But it looks like libvirt uses it - and should stumble over this breakage (it does not specify a device name). I can fix it by removing the silly auto-naming, or can libvirt live without it? Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux