From: Jeremy Fitzhardinge Subject: Re: [PATCH 03/20] x86/ticketlock: Use C for __ticket_spin_unlock Date: Wed, 03 Nov 2010 14:00:30 -0400 Message-ID: <4CD1A33E.6040105@goop.org> References: <20092775a9df07a5a75820ac250194b535279d51.1288794124.git.jeremy.fitzhardinge@citrix.com> <1288797218.2511.143.camel@edumazet-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1288797218.2511.143.camel@edumazet-laptop> Sender: linux-kernel-owner@vger.kernel.org To: Eric Dumazet Cc: Peter Zijlstra , Linux Kernel Mailing List , Jan Beulich , Avi Kivity , Xen-devel , "H. Peter Anvin" , Linux Virtualization , Srivatsa Vaddagiri , Jeremy Fitzhardinge List-Id: xen-devel@lists.xenproject.org On 11/03/2010 11:13 AM, Eric Dumazet wrote: > Le mercredi 03 novembre 2010 =C3=A0 10:59 -0400, Jeremy Fitzhardinge = a > =C3=A9crit : >> From: Jeremy Fitzhardinge >> >> If we don't need to use a locked inc for unlock, then implement it i= n C. >> >> Signed-off-by: Jeremy Fitzhardinge >> --- >> arch/x86/include/asm/spinlock.h | 33 ++++++++++++++++++----------= ----- >> 1 files changed, 18 insertions(+), 15 deletions(-) >> >> diff --git a/arch/x86/include/asm/spinlock.h b/arch/x86/include/asm/= spinlock.h >> index 6711d36..082990a 100644 >> --- a/arch/x86/include/asm/spinlock.h >> +++ b/arch/x86/include/asm/spinlock.h >> @@ -33,9 +33,23 @@ >> * On PPro SMP or if we are using OOSTORE, we use a locked operatio= n to unlock >> * (PPro errata 66, 92) >> */ >> -# define UNLOCK_LOCK_PREFIX LOCK_PREFIX >> +static __always_inline void __ticket_unlock_release(struct arch_spi= nlock *lock) >> +{ >> + if (sizeof(lock->tickets.head) =3D=3D sizeof(u8)) >> + asm (LOCK_PREFIX "incb %0" >> + : "+m" (lock->tickets.head) : : "memory"); >> + else >> + asm (LOCK_PREFIX "incw %0" >> + : "+m" (lock->tickets.head) : : "memory"); >> + >> +} >> #else >> -# define UNLOCK_LOCK_PREFIX >> +static __always_inline void __ticket_unlock_release(struct arch_spi= nlock *lock) >> +{ >> + barrier(); > technically speaking, it should be : smp_wmb() Perhaps. In practise it won't make a difference because it is defined as barrier() unless OOSTORE is defined, in which case we need to do a locked increment anyway. Thanks, J