From: Jens Axboe Subject: Re: [PATCH] block: read i_size with i_size_read() Date: Sun, 7 Nov 2010 12:45:39 +0100 Message-ID: <4CD69163.1030407@fusionio.com> References: <1288985241-3515-1-git-send-email-snitzer@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: "linux-kernel@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , Neil Brown , "drbd-dev@lists.linbit.com" To: Mike Snitzer Return-path: In-Reply-To: <1288985241-3515-1-git-send-email-snitzer@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On 2010-11-05 20:27, Mike Snitzer wrote: > Convert direct reads of an inode's i_size to using i_size_read(). > > i_size_{read,write} use a seqcount to protect reads from accessing > incomple writes. Concurrent i_size_write()s require mutual exclussion > to protect the seqcount that is used by i_size_{read,write}. But > i_size_read() callers do not need to use additional locking. Thanks Mike, I'll queue this up. -- Jens Axboe