From: Henrik Rydberg Date: Wed, 10 Nov 2010 19:56:20 +0000 Subject: Re: [lm-sensors] [PATCH] hwmon: (applesmc) Fix checkpatch errors Message-Id: <4CDAF8E4.7030609@euromail.se> List-Id: References: <1289415200-4928-1-git-send-email-guenter.roeck@ericsson.com> <4CDAE9D7.3060007@euromail.se> <20101110193930.GA31650@ericsson.com> In-Reply-To: <20101110193930.GA31650@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Guenter Roeck Cc: Jean Delvare , "lm-sensors@lm-sensors.org" , "linux-kernel@vger.kernel.org" >>> @@ -977,7 +975,11 @@ static ssize_t applesmc_key_at_index_show >>> static ssize_t applesmc_key_at_index_store(struct device *dev, >>> struct device_attribute *attr, const char *sysfsbuf, size_t count) >>> { >>> - key_at_index = simple_strtoul(sysfsbuf, NULL, 10); >>> + unsigned long newkey; >>> + >>> + if (strict_strtoul(sysfsbuf, 10, &newkey) < 0) >>> + return -EINVAL; >>> + key_at_index = newkey; >> >> >> Crash alert - key_at_index is not range checked, and the remake uses this value >> as an array index... >> > Good that I made this change ;). I'll add the check and re-send. Indeed! The downside of remakes... sorry about that. :-) I guess the change should go into patch 4 already? There is also the option to put the bounds check in applesmc_get_entry_by_index, but I like the simplicity of "|| newkey >= smcreg.key_count". > This points to another problem, though. You allocate key_count entries, > ie cache[0]..cache[key_count-1]. Yet, the key searches are from 0..key_count, > ie span key_count+1 entries. Is that another problem ? > > Seems to me you would either have to allocate key_count+1 entries, or terminate > the search at key_count - 1. Not sure which one would be correct. Let me know, > and I'll update the affected patch(es). If you are referring to the lower and upper bound functions, those use the one-past-the-last-element convention, so it is actually still 0..key_count - 1. I stayed very close to the stl reference implementation, which relies on the fact that when begin != end, (begin + (end - begin) / 2) < end. Cheers, Henrik _______________________________________________ lm-sensors mailing list lm-sensors@lm-sensors.org http://lists.lm-sensors.org/mailman/listinfo/lm-sensors